Skip to Content

P0 Checklist

This list is a practical, minimal, non-exhaust checklist that contains the P0 area to look for when reviewing a PR. This can be seen as a best practice list to both PR reviewer and PR author.

Contributing

Given this list is of the top priority, we would like to keep it minimal and consensual. To make it to this list, the corresponding rule must be thoroughly discussed and reviewed by the code review committee.

  • Always keep your terraform code and other code in separate PRs.

    Terraform code uses apply for deployment, they should not be mixed together with the regular code change.

  • Always verify the result of atlantis apply and add the result to test plan

    Atlantis apply is the final step of the terraform deployment, it is important to verify the result and add it to the test plan.

Last updated on